Conversation
individual-it
requested review from
TheOneRing,
Copilot and
prashant-gurung899
and removed request for
Copilot
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR re-enables Virtual File System (VFS) tests that were previously disabled, allowing them to run for functionality that should already be working. The changes focus on setting up proper VFS configuration and test infrastructure.
Key changes:
- Adds VFS test suite with BDD-style feature tests for copy/paste and move operations on virtual files
- Configures Windows clients to use 'cfapi' virtual files mode instead of 'off'
- Fixes file size detection for virtual files on Windows with proper synchronization
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/gui/tst_vfs/test.py | New test runner for VFS BDD tests |
| test/gui/tst_vfs/test.feature | BDD feature file defining VFS copy/paste and move scenarios |
| test/gui/shared/scripts/helpers/SetupClientHelper.py | Updates client configuration to enable VFS on Windows |
| test/gui/shared/scripts/helpers/FilesHelper.py | Fixes file size detection for virtual files with proper wait logic |
individual-it
force-pushed
the
vfsTestsPart1
branch
from
ba1317d to
e8a54e9
Compare
individual-it
force-pushed
the
vfsTestsPart1
branch
3 times, most recently
from
c9229f0 to
b72e2e9
Compare
anon-pradip
approved these changes
Dec 9, 2025
individual-it
force-pushed
the
vfsTestsPart1
branch
from
b72e2e9 to
fc4090b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #376 & #391 just making those tests run that should already work
This contains also #584 and #585, so should be merged after those PRs
Also the tests fail because of #578